Enable CMAKE_MSVC_RUNTIME_LIBRARY support via CMP0091 policy#566
Open
RahulRaj272727 wants to merge 1 commit intomachinezone:masterfrom
Open
Enable CMAKE_MSVC_RUNTIME_LIBRARY support via CMP0091 policy#566RahulRaj272727 wants to merge 1 commit intomachinezone:masterfrom
RahulRaj272727 wants to merge 1 commit intomachinezone:masterfrom
Conversation
This change enables users to configure the MSVC runtime library using CMAKE_MSVC_RUNTIME_LIBRARY (e.g., MultiThreaded or MultiThreadedDebug) for static linking scenarios. Without this policy set to NEW, CMAKE_MSVC_RUNTIME_LIBRARY is ignored, making it impossible to build with static runtime (/MT, /MTd) via CMake parameters alone. The conditional check ensures backward compatibility with CMake versions prior to 3.15 where CMP0091 doesn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables users to configure the MSVC runtime library using
CMAKE_MSVC_RUNTIME_LIBRARY(e.g.,MultiThreadedorMultiThreadedDebug) for static linking scenarios on Windows.Problem
Without the
CMP0091policy set toNEW, theCMAKE_MSVC_RUNTIME_LIBRARYCMake variable is ignored. This makes it impossible to build with static runtime (/MT,/MTd) via CMake parameters alone.Solution
Add a conditional policy check that:
CMP0091when available (CMake 3.15+)Example Usage
After this change, users can build with a static runtime: